Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup GH Actions [ch32361] #44

Merged
merged 2 commits into from
Jul 28, 2021
Merged

Conversation

hassansin
Copy link
Contributor

No description provided.

@hassansin hassansin requested a review from pkopac July 16, 2021 06:15
@shortcut-integration
Copy link

This pull request has been linked to Clubhouse Story #32361: Support GH Actions.

@hassansin hassansin force-pushed the hassansin/ch32361/support-gh-actions branch from 1cb5643 to 4b2f9db Compare July 16, 2021 06:16
@hassansin hassansin force-pushed the hassansin/ch32361/support-gh-actions branch from 4b2f9db to 1708778 Compare July 16, 2021 06:18
@codeclimate
Copy link

codeclimate bot commented Jul 16, 2021

Code Climate has analyzed commit 9b6b99f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 48.1%.

View more on Code Climate.

runs-on: ubuntu-latest
strategy:
matrix:
go-versions: ['1.11', '1.12', '1.13', '1.14']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not go 1.16?

@@ -91,6 +91,9 @@ var matchersCases = map[string]struct {
func TestErrorMatchers(t *testing.T) {
for testName, testCase := range matchersCases {
for fnName, expected := range testCase.expectations {
t := t
expected := expected
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

@hassansin hassansin merged commit 4d1334a into main Jul 28, 2021
@hassansin hassansin deleted the hassansin/ch32361/support-gh-actions branch July 28, 2021 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants