Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .gitattributes to exclude more useless files #109

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

VincentLanglet
Copy link
Contributor

Hi @pkopac @sbrych

I found more entries which could be added to the .gitattributes files
This is similar to #103

@pkopac pkopac requested a review from sbrych July 31, 2023 07:06
@VincentLanglet
Copy link
Contributor Author

Friendly ping @pkopac @sbrych

@pkopac pkopac requested a review from swember September 7, 2023 12:03
@sbrych
Copy link
Contributor

sbrych commented Sep 14, 2023

Friendly ping @pkopac @sbrych

Hey @VincentLanglet, apologies for the late response, life got in the way :)
Thank you for the PR, We'll merge it as soon as we're done with some underlying issues (failing test suite for example)

@VincentLanglet
Copy link
Contributor Author

Friendly ping @pkopac @sbrych

Hey @VincentLanglet, apologies for the late response, life got in the way :) Thank you for the PR, We'll merge it as soon as we're done with some underlying issues (failing test suite for example)

Hi, I rebased and there are less (unrelated) failure but still some.
Should I do something ? Thanks :)

@VincentLanglet
Copy link
Contributor Author

I fixed the ci @sbrych @pkopac

@sbrych
Copy link
Contributor

sbrych commented Oct 19, 2023

Thank you @VincentLanglet, merging now

@sbrych sbrych merged commit f40743f into chartmogul:main Oct 19, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants