Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop abstract static methods [ch4671] #40

Merged
merged 8 commits into from
Jul 24, 2018
Merged

Drop abstract static methods [ch4671] #40

merged 8 commits into from
Jul 24, 2018

Conversation

hassansin
Copy link
Contributor

  • Removed abstract static method
  • Updated Travis script to test against multiple PHP versions
  • Updated Dockerfile to test against multiple PHP versions locally
  • Added php.ini to enable strict warnings durings unit tests
  • Some code formatting & unit tests

en0ma
en0ma approved these changes Jul 24, 2018
View reviewed changes
Copy link

@en0ma en0ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hassansin hassansin merged commit 1d607be into master Jul 24, 2018
@hassansin hassansin deleted the hassansin/ch4671/remove-abstract-static-methods branch July 24, 2018 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkopac pkopac pkopac approved these changes

@en0ma en0ma en0ma approved these changes

@bogdanguranda bogdanguranda Awaiting requested review from bogdanguranda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hassansin @pkopac @en0ma