Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@types/node as dev dependency? #78

Closed
orta opened this issue May 22, 2017 · 1 comment
Closed

@types/node as dev dependency? #78

orta opened this issue May 22, 2017 · 1 comment

Comments

@orta
Copy link
Contributor

orta commented May 22, 2017

Hello there, lovely library! I'm using it as a transitive dependency of yoga which I'm using in a React Native project. React Native isn't strictly a node environment (it's running on the JS interpreter inside an App.)

I'm using Yoga as a dev dependency which is used by Jest ( which does run on node) but the d.tss for React Native and Node conflict, as RN has a subset of the same API re-implmented.

I'm looking inside TypeScript at the moment to see if there's a way for me to exclude this dependency at the tsconfig level, but at the same time I thought it was worth asking if you'd accept a PR moving this dependency to be a dev one?

@orta
Copy link
Contributor Author

orta commented May 29, 2017

Fixed with #554

@orta orta closed this as completed May 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant