Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'No missing ID's' when there are missing IDs #125

Open
chasemc opened this issue Jun 21, 2019 · 0 comments
Open

'No missing ID's' when there are missing IDs #125

chasemc opened this issue Jun 21, 2019 · 0 comments
Assignees
Labels
Projects

Comments

@chasemc
Copy link
Owner

chasemc commented Jun 21, 2019

When entering IDs for the Bruker conversion 'No missing ID's' is displayed no matter what after saving.

Relevant

anyMissing <- reactive({
req(rawFilesLocation())
req(sampleMapReactive$rt)
acquisitonInformation1 <<- acquisitonInformation
sampleMapReactive1 <<- sampleMapReactive
spots <- unlist(lapply(acquisitonInformation(), function(x) x$spot))
IDBacApp::findMissingSampleMapIds(spots = spots,
sampleMap = sampleMapReactive$rt)
})
output$missingSampleNames <- shiny::renderText({
if (length(anyMissing()$missing) == 0) {
paste0("No missing IDs")
} else {
paste0(paste0(anyMissing()$missing, collapse = " \n ", sep = ","))
}
})

Also, update unit test:
https://github.com/chasemc/IDBacApp/blob/6bed5abdee2b09b6e128ba623539b34d5e16e412/tests/testthat/test-findmissingsamplemapids.R

@chasemc chasemc added the bug label Jun 21, 2019
@chasemc chasemc self-assigned this Jun 21, 2019
@chasemc chasemc added this to To do in 1.2.0 Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
1.2.0
  
To do
Development

No branches or pull requests

1 participant