Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev fix csv loader #3404

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Conversation

oslijunw
Copy link
Contributor

In the original csv loader, although columns_to_read is of List[str] type, only the first value of columns_to_read is obtained in the specific logic. This has been improved so that the logic can read multiple fields normally.

原来的csv加载器中,虽然columns_to_read是List[str]类型,但是具体逻辑中只获取了columns_to_read的第一个值,这里进行了完善,使得逻辑能够正常读取多个字段

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Mar 18, 2024
@oslijunw
Copy link
Contributor Author

Request a code review

@oslijunw
Copy link
Contributor Author

Request a code review

@imClumsyPanda @liunux4odoo tks

@Mosley-Z
Copy link

刚排查到这个问题就看到你的方案,如同天降甘霖啊,感谢

@liunux4odoo
Copy link
Collaborator

感谢您的贡献。

@liunux4odoo liunux4odoo merged commit 07b7c96 into chatchat-space:master Mar 20, 2024
dignfei pushed a commit to dignfei/Langchain-Chatchat that referenced this pull request Apr 8, 2024
* fix: csv loader only load one column

* csv data merge with col name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants