Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incorrect arg order and support zero his #73

Merged
merged 1 commit into from
Apr 13, 2023
Merged

incorrect arg order and support zero his #73

merged 1 commit into from
Apr 13, 2023

Conversation

lurenlym
Copy link
Contributor

  1. webui.py 传参顺序LLM_HISTORY_LEN和VECTOR_SEARCH_TOP_K反了
  2. 支持历史记录为0的情况，即不传输历史对话记录

calcitem
calcitem requested changes Apr 13, 2023
View reviewed changes
webui.py
@@ -95,7 +95,7 @@ def get_file_status(history):
kb.init_cfg(args[0], args[1], args[2], args[3]),
show_progress=True,
api_name="init_cfg",
inputs=[llm_model, embedding_model, VECTOR_SEARCH_TOP_K, LLM_HISTORY_LEN]
inputs=[llm_model, embedding_model, LLM_HISTORY_LEN,VECTOR_SEARCH_TOP_K]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里加个换行更好？

@imClumsyPanda imClumsyPanda merged commit 5c9e931 into chatchat-space:master Apr 13, 2023
@lurenlym lurenlym deleted the dev branch April 17, 2023 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calcitem calcitem calcitem requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lurenlym @calcitem @imClumsyPanda