Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added feature to pre-label elements #5

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Added feature to pre-label elements #5

merged 1 commit into from
Mar 16, 2023

Conversation

mefengl
Copy link
Contributor

@mefengl mefengl commented Mar 16, 2023 •
edited

#2

@adamlui adamlui merged commit 7b12682 into KudoAI:main Mar 16, 2023
@adamlui
Copy link
Member

adamlui commented Mar 16, 2023

@mefengl Actually this will still return the wrong button if coder uses chatgpt.getSubmitButton() somewhere in his script and user has scripts installed that change button order, since chatgpt.getSubmitButton() is not relying on the newly assigned IDs

@adamlui
Copy link
Member

adamlui commented Mar 16, 2023

And users would naturally type var sendButton = chatgpt.getSubmitButton() and not deal with IDs, so the functions themselves need to work instead (I fixed the submit one already)

Rojojun added a commit to Rojojun/chatgpt.js that referenced this pull request Jul 14, 2023
@Rojojun
[fix] SECURITY.md translate into korean KudoAI#5
2547090
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mefengl @adamlui