Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anyway to prevent send message after pressing "Enter" key? #28

Closed
bibek-magar opened this issue Apr 12, 2021 · 7 comments · Fixed by #41
Closed

Anyway to prevent send message after pressing "Enter" key? #28

bibek-magar opened this issue Apr 12, 2021 · 7 comments · Fixed by #41
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers released

Comments

@bibek-magar
Copy link

bibek-magar commented Apr 12, 2021

I want my message line break on enter press rather than shift + enter..
How do I prevent default behaviour of sending messages on enter pressed!!!

@supersnager
Copy link
Contributor

@beevekmgr How do you want to send messages? Only using send button?

@supersnager supersnager self-assigned this Apr 12, 2021
@supersnager supersnager added good first issue Good for newcomers enhancement New feature or request labels Apr 12, 2021
@bibek-magar
Copy link
Author

Um... yes actually "enter" key is use to switch language in japanese . which is causing a problem.

@supersnager
Copy link
Contributor

@beevekmgr Ok, I will add a property to disable send on enter

@supersnager
Copy link
Contributor

@VincentRoest, thank you for your awesome work!
I want to merge your PR, but the commit message needs to meet conventional commit requirements.
Please see my PR comment for the details.

@bibek-magar
Copy link
Author

@supersnager still waiting this to be merged...

@supersnager
Copy link
Contributor

🎉 This issue has been resolved in version 1.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@supersnager
Copy link
Contributor

Sorry guys for having to wait. I forgot that that commit message can be changed before merge :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants