Refactoring and Addition of Test cases #506
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efactored code in updateInfo() and added several class which is the part of refactoring. [2]ColorCorrectionNew.java - Introduced explaining variables in makeBrighter(). [3]Helper.java - Decomposed the conditional to make it easier to understand.(Introduced two new variables to make it easy to understand).
Kapadiatathya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some tests to increase the branch and test coverage and the refactoring is done as follows:
[1]ChannelState.java - Refactored code in updateInfo() and added several classes which is part of refactoring. [2]ColorCorrectionNew.java - Introduced explaining variables in makeBrighter().
[3]Helper.java - Decomposed the conditional to make it easier to understand. (Introduced two new variables to make it easy to understand).