Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConfigMap should not contain credentials #46

Closed
davidspek opened this issue Jan 5, 2022 · 1 comment
Closed

ConfigMap should not contain credentials #46

davidspek opened this issue Jan 5, 2022 · 1 comment
Assignees
@vishnu-narayanan
Labels
enhancement New feature or request

Comments

@davidspek
Copy link
Contributor

The ConfigMap used to set the environment variables contains many passwords or associated secrets. Rather than using a ConfigMap, it would be better to use a secret to store these values.
@davidspek davidspek mentioned this issue Jan 5, 2022
Merged
@vishnu-narayanan
Copy link
Member

Closing as #47 is merged

@vishnu-narayanan vishnu-narayanan added the enhancement New feature or request label Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vishnu-narayanan vishnu-narayanan

Labels
enhancement New feature or request
Projects
Engineering Board
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vishnu-narayanan @davidspek