Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add automated end-to-end testing using detox #230

Merged
merged 9 commits into from
Sep 11, 2020
Merged

Feature: add automated end-to-end testing using detox #230

merged 9 commits into from
Sep 11, 2020

Conversation

arufanov
Copy link
Contributor

@arufanov arufanov commented Sep 9, 2020

@muhsin-k here is pull requests for #30 PR contain setup for iOS with single simple tests. There are some issues about PR:

  • tests are not included in CI.
  • which ios configuration should be tested: debug or release? Now is debug, it is discussable.
  • I haven't test with android, should I?
  • e2e dir excluded from eslint check. Looks like not OK, and should be fixed. What do you thing?
  • simulator should be run before run tests. It is looks like bug, I am researching.

Any feedback is welcome.

@muhsin-k
Copy link
Member

muhsin-k commented Sep 10, 2020

@arufanov Thank you for this fantastic PR.
I haven't test with android, should I?
Is there any challenges that are blocking android?
E2E dir excluded from eslint check. Looks like not OK, and should be fixed. What do you thing?
It is okay
The PR looks good to me. Is it possible to share the working screencast?

@arufanov
Copy link
Contributor Author

arufanov commented Sep 10, 2020

@arufanov Thank you for this fantastic PR.
I haven't test with android, should I?
Is there any challenges that are blocking android?

No, there isn't any blocking challenges as far as I can see, environment is not ready.

E2E dir excluded from eslint check. Looks like not OK, and should be fixed. What do you thing?
It is okay

This issue have been fixed.

The PR looks good to me. Is it possible to share the working screencast?

Sure, I have attached screencast. Screen Recording 2020-09-10 at 14.21.17.mov.zip Pay attention: simulator should be pre run (need extra step in ci), otherwise error will occurs. I will try to understand is it ok on "hello world" example. After it I remove WIP (=work in progress) value. Let me know if it is not essential for you.

P.S.
I would be great if you add me to project with rights to create a branch and PR. It allow me to avoid fork repo on every PR. Thanks!

@arufanov
Copy link
Contributor Author

@muhsin-k

  • fixed "simulator should be run before run tests. It is looks like bug, I am researching." It was my problem, fixed by erasing all simulators.

I suppose PR is ready, any feedback is welcome! Otherwise would be great to see it develop branch.

@arufanov arufanov marked this pull request as ready for review September 10, 2020 14:07
@muhsin-k muhsin-k requested review from muhsin-k and removed request for muhsin-k September 10, 2020 14:23
@muhsin-k muhsin-k self-assigned this Sep 10, 2020
@muhsin-k muhsin-k linked an issue Sep 10, 2020 that may be closed by this pull request
@muhsin-k muhsin-k changed the title Feature 30 support detox Feature: add automated end-to-end testing using detox Sep 10, 2020
@muhsin-k
Copy link
Member

@arufanov I will merge the PR once I test it out in my local machine.

@muhsin-k
Copy link
Member

P.S.
I would be great if you add me to project with rights to create a branch and PR. It allow me to avoid fork repo on every PR. Thanks!

@arufanov We have added you as a contributor 🙂. All types of contributions are welcome.

@muhsin-k muhsin-k merged commit 1f5feca into chatwoot:develop Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup automated end-to-end testing using Detox (iOS)
2 participants