-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: add automated end-to-end testing using detox #230
Conversation
@arufanov Thank you for this fantastic PR. |
No, there isn't any blocking challenges as far as I can see, environment is not ready.
This issue have been fixed.
Sure, I have attached screencast. Screen Recording 2020-09-10 at 14.21.17.mov.zip Pay attention: simulator should be pre run (need extra step in ci), otherwise error will occurs. I will try to understand is it ok on "hello world" example. After it I remove WIP (=work in progress) value. Let me know if it is not essential for you. P.S. |
I suppose PR is ready, any feedback is welcome! Otherwise would be great to see it develop branch. |
@arufanov I will merge the PR once I test it out in my local machine. |
@arufanov We have added you as a contributor 🙂. All types of contributions are welcome. |
@muhsin-k here is pull requests for #30 PR contain setup for iOS with single simple tests. There are some issues about PR:
Any feedback is welcome.