feat: Show password on login screen #751
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@muhsin-k I created a pull request to add the eye for V2 of the app for the password on the login page |
muhsin-k
reviewed
Dec 5, 2023
muhsin-k
reviewed
Dec 5, 2023
muhsin-k
changed the title
muhsin-k
reviewed
Feb 19, 2024
| @@ -191,15 +191,19 @@ const ConversationParticipants = ({ conversationId }) => { | |||
| <View /> | |||
| )} | |||
| {isCurrentUserWatching ? ( | |||
| <Text sm color={colors.textGrayLighter}> | |||
| <Text accessible={true} sm color={colors.textGrayLighter}> | |||
There was a problem hiding this comment.
Lets do the all the accessibility changes in a separate PR.
muhsin-k
reviewed
Feb 19, 2024
|
Closing this since there hasn't been any activity on this for a while. Let's reopen if required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Implemented the showing and hiding of password on the login screen, by adding a touchable eye image that changes the security of the password field
Fixes #506
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: