Skip to content

Commit

Permalink
chore: Create client API conversations with custom attributes (#8040)
Browse files Browse the repository at this point in the history
- Update client API create conversations endpoint to accept custom attributes as well.
  • Loading branch information
sojan-official committed Oct 4, 2023
1 parent e4de366 commit 336af1a
Show file tree
Hide file tree
Showing 6 changed files with 46 additions and 7 deletions.
Expand Up @@ -33,19 +33,14 @@ def set_conversation
end

def create_conversation
::Conversation.create!(conversation_params)
ConversationBuilder.new(params: conversation_params, contact_inbox: @contact_inbox).perform
end

def trigger_typing_event(event)
Rails.configuration.dispatcher.dispatch(event, Time.zone.now, conversation: @conversation, user: @conversation.contact)
end

def conversation_params
{
account_id: @contact_inbox.contact.account_id,
inbox_id: @contact_inbox.inbox_id,
contact_id: @contact_inbox.contact_id,
contact_inbox_id: @contact_inbox.id
}
params.permit(custom_attributes: {})
end
end
Expand Up @@ -44,6 +44,17 @@
data = response.parsed_body
expect(data['id']).not_to be_nil
end

it 'creates a conversation with custom attributes but prevents other attributes' do
post "/public/api/v1/inboxes/#{api_channel.identifier}/contacts/#{contact_inbox.source_id}/conversations",
params: { custom_attributes: { 'test' => 'test' }, additional_attributes: { 'test' => 'test' } }

expect(response).to have_http_status(:success)
data = response.parsed_body
conversation = api_channel.inbox.conversations.find_by(display_id: data['id'])
expect(conversation.custom_attributes).to eq('test' => 'test')
expect(conversation.additional_attributes).to be_empty
end
end

describe 'POST /public/api/v1/inboxes/{identifier}/contact/{source_id}/conversations/{conversation_id}/toggle_typing' do
Expand Down
3 changes: 3 additions & 0 deletions swagger/definitions/index.yml
Expand Up @@ -138,6 +138,9 @@ public_message_create_payload:
public_message_update_payload:
$ref: ./request/public/message/update_payload.yml

public_conversation_create_payload:
$ref: ./request/public/conversation/create_payload.yml

## ---------- RESPONSE ------------- ##
## -------------------------------- ##

Expand Down
@@ -0,0 +1,5 @@
type: object
properties:
custom_attributes:
type: object
description: Custom attributes of the conversation
6 changes: 6 additions & 0 deletions swagger/paths/public/inboxes/conversations/create.yml
Expand Up @@ -4,6 +4,12 @@ operationId: create-a-conversation
summary: Create a conversation
description: Create a conversation
security: []
parameters:
- name: data
in: body
required: true
schema:
$ref: '#/definitions/public_conversation_create_payload'
responses:
200:
description: Success
Expand Down
19 changes: 19 additions & 0 deletions swagger/swagger.json
Expand Up @@ -847,6 +847,16 @@
"description": "Create a conversation",
"security": [

],
"parameters": [
{
"name": "data",
"in": "body",
"required": true,
"schema": {
"$ref": "#/definitions/public_conversation_create_payload"
}
}
],
"responses": {
"200": {
Expand Down Expand Up @@ -6617,6 +6627,15 @@
}
}
},
"public_conversation_create_payload": {
"type": "object",
"properties": {
"custom_attributes": {
"type": "object",
"description": "Custom attributes of the conversation"
}
}
},
"extended_contact": {
"allOf": [
{
Expand Down

0 comments on commit 336af1a

Please sign in to comment.