Skip to content

Commit

Permalink
chore: Improvements to dark mode usage in widget (#7873)
Browse files Browse the repository at this point in the history
  • Loading branch information
nithindavid committed Sep 11, 2023
1 parent f05535c commit 8d43101
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 12 deletions.
11 changes: 2 additions & 9 deletions app/javascript/widget/App.vue
Expand Up @@ -41,15 +41,15 @@ import {
ON_CAMPAIGN_MESSAGE_CLICK,
ON_UNREAD_MESSAGE_CLICK,
} from './constants/widgetBusEvents';
import darkModeMixin from 'widget/mixins/darkModeMixin';
import { SDK_SET_BUBBLE_VISIBILITY } from '../shared/constants/sharedFrameEvents';
export default {
name: 'App',
components: {
Spinner,
},
mixins: [availabilityMixin, configMixin, routerMixin],
mixins: [availabilityMixin, configMixin, routerMixin, darkModeMixin],
data() {
return {
isMobile: false,
Expand All @@ -67,7 +67,6 @@ export default {
isFetchingList: 'conversation/getIsFetchingList',
isRightAligned: 'appConfig/isRightAligned',
isWidgetOpen: 'appConfig/getIsWidgetOpen',
darkMode: 'appConfig/darkMode',
messageCount: 'conversation/getMessageCount',
unreadMessageCount: 'conversation/getUnreadMessageCount',
isWidgetStyleFlat: 'appConfig/isWidgetStyleFlat',
Expand All @@ -78,12 +77,6 @@ export default {
isRNWebView() {
return RNHelper.isRNWebView();
},
prefersDarkMode() {
const isOSOnDarkMode =
this.darkMode === 'auto' &&
window.matchMedia('(prefers-color-scheme: dark)').matches;
return isOSOnDarkMode || this.darkMode === 'dark';
},
},
watch: {
activeCampaign() {
Expand Down
3 changes: 1 addition & 2 deletions app/javascript/widget/components/AgentMessageBubble.vue
Expand Up @@ -9,8 +9,7 @@
>
<div
v-dompurify-html="formatMessage(message, false)"
class="message-content"
:class="$dm('text-black-900', 'dark:text-slate-50')"
class="message-content text-slate-900 dark:text-slate-50"
/>
<email-input
v-if="isTemplateEmail"
Expand Down
5 changes: 4 additions & 1 deletion app/javascript/widget/components/layouts/ViewWithHeader.vue
Expand Up @@ -46,7 +46,10 @@
>
<router-view />
</transition>
<branding :disable-branding="disableBranding" />
<branding
class="bg-slate-25 dark:bg-slate-800"
:disable-branding="disableBranding"
/>
</div>
</template>
<script>
Expand Down

0 comments on commit 8d43101

Please sign in to comment.