fix: Prevents duplicate action trigger on interactive messages (#6448)

Co-authored-by: raph941 <45232708+raph941@users.noreply.github.com> Co-authored-by: phunguyenmurcul <51897872+phunguyenmurcul@users.noreply.github.com>
chatwoot · Feb 14, 2023 · 97b1b4c · 97b1b4c
1 parent 98ff185
commit 97b1b4c
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 2 deletions.
diff --git a/app/javascript/widget/store/modules/message.js b/app/javascript/widget/store/modules/message.js
@@ -12,9 +12,12 @@ export const getters = {
 
 export const actions = {
   update: async (
-    { commit, dispatch },
+    { commit, dispatch, getters: { getUIFlags: uiFlags } },
     { email, messageId, submittedValues }
   ) => {
+    if (uiFlags.isUpdating) {
+      return;
+    }
     commit('toggleUpdateStatus', true);
     try {
       await MessageAPI.update({

diff --git a/app/javascript/widget/store/modules/specs/message/actions.spec.js b/app/javascript/widget/store/modules/specs/message/actions.spec.js
@@ -17,7 +17,17 @@ describe('#actions', () => {
       API.patch.mockResolvedValue({
         data: { contact: { pubsub_token: '8npuMUfDgizrwVoqcK1t7FMY' } },
       });
-      await actions.update({ commit }, user);
+      await actions.update(
+        {
+          commit,
+          getters: {
+            getUIFlags: {
+              isUpdating: false,
+            },
+          },
+        },
+        user
+      );
       expect(commit.mock.calls).toEqual([
         ['toggleUpdateStatus', true],
         [
@@ -34,5 +44,21 @@ describe('#actions', () => {
         ['toggleUpdateStatus', false],
       ]);
     });
+
+    it('blocks all new action calls when isUpdating', async () => {
+      await actions.update(
+        {
+          commit,
+          getters: {
+            getUIFlags: {
+              isUpdating: true,
+            },
+          },
+        },
+        {}
+      );
+
+      expect(commit.mock.calls).toEqual([]);
+    });
   });
 });