Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warning "center is not a valid value for vertical alignment. Use top, bottom, middle, or stretch." #115

Closed
pranavrajs opened this issue Oct 5, 2019 · 4 comments
Closed

Fix warning "center is not a valid value for vertical alignment. Use top, bottom, middle, or stretch." #115

pranavrajs opened this issue Oct 5, 2019 · 4 comments
Assignees
@nithindavid
Labels
frontend Involves working with javascript ( Vue JS / CSS ) Good first issue If you are new and looking to contribute hacktoberfest Issues to work during hacktoberfest

Comments

@pranavrajs
Copy link
Member

pranavrajs commented Oct 5, 2019 •
edited by nithindavid

WARNING: flex-grid-row-align(): center is not a valid value for vertical alignment. Use top, bottom, middle, or stretch.

16:42:10 frontend.1 | WARNING: flex-grid-row-align(): center is not a valid value for vertical alignment. Use top, bottom, middle, or stretch.
16:42:10 frontend.1 |          on line 47 of node_modules/foundation-sites/scss/util/_flex.scss, in mixin `flex-align`
16:42:10 frontend.1 |          from line 68 of app/javascript/src/assets/scss/widgets/_modal.scss
16:42:10 frontend.1 |          from line 20 of app/javascript/src/assets/scss/_woot.scss
16:42:10 frontend.1 |          from line 9 of app/javascript/src/assets/scss/app.scss
16:42:10 frontend.1 |          from line 28 of stdin
@pranavrajs pranavrajs added frontend Involves working with javascript ( Vue JS / CSS ) hacktoberfest Issues to work during hacktoberfest labels Oct 5, 2019
@nithindavid nithindavid self-assigned this Oct 7, 2019
@nithindavid
Copy link
Contributor

The fix is simple app/javascript/src/assets/scss/widgets/_modal.scss has
@include flex-align($x: justify, $y: center);.
We need to pass middle instead center for $y: .

@nithindavid nithindavid added the Good first issue If you are new and looking to contribute label Oct 7, 2019
@nithindavid nithindavid changed the title WARNING: flex-grid-row-align(): center is not a valid value for vertical alignment. Use top, bottom, middle, or stretch. Fix warning "center is not a valid value for vertical alignment. Use top, bottom, middle, or stretch." Oct 8, 2019
@the-spectator
Copy link
Contributor

@nithindavid Can I apply your suggested fix?

@nithindavid
Copy link
Contributor

@the-spectator Yes please 😄 Go ahead.

the-spectator pushed a commit to the-spectator/chatwoot that referenced this issue Oct 16, 2019
Fixes chatwoot#115
cc172dc 
Use middle instead of centre in flex-align
Co-authored-by: Nithin <webofnithin@gmail.com>
the-spectator pushed a commit to the-spectator/chatwoot that referenced this issue Oct 16, 2019
Fixes chatwoot#115 Use middle instead of centre in flex-align
2e2fcad 
Co-authored-by: Nithin <webofnithin@gmail.com>
the-spectator pushed a commit to the-spectator/chatwoot that referenced this issue Oct 16, 2019
@nithindavid
Fixes chatwoot#115 Use middle instead of centre in flex-align
092e914 
Co-authored-by: Nithin <webofnithin@gmail.com>
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nithindavid nithindavid

Labels
frontend Involves working with javascript ( Vue JS / CSS ) Good first issue If you are new and looking to contribute hacktoberfest Issues to work during hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nithindavid @pranavrajs @the-spectator