Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity message for mute / unmute conversation #1330

Closed
pranavrajs opened this issue Oct 9, 2020 · 12 comments
Closed

Activity message for mute / unmute conversation #1330

pranavrajs opened this issue Oct 9, 2020 · 12 comments
Assignees
Labels
backend Changes related to backend / ruby code Good first issue If you are new and looking to contribute hacktoberfest Issues to work during hacktoberfest
Milestone

Comments

@pranavrajs
Copy link
Member

When an agent mute/unmute the converstion, add an activity message "#{agent_name} has muted the conversation"

@pranavrajs pranavrajs added Enhancement Good first issue If you are new and looking to contribute backend Changes related to backend / ruby code hacktoberfest Issues to work during hacktoberfest labels Oct 9, 2020
@TravisGM92
Copy link

TravisGM92 commented Oct 9, 2020

@pranavrajs Can I start working on this issue? Also a point of clarification (and this will be my first time contributing to chatwoot so please be patient with me); is 'activity message' the same as 'flash message'?

@pranavrajs
Copy link
Member Author

pranavrajs commented Oct 9, 2020

@TravisGM92 Feel free to take this. Activity message is a type of message (See message_type in https://github.com/chatwoot/chatwoot/blob/develop/app/models/message.rb#L42)

You can refer to https://github.com/chatwoot/chatwoot/pull/1291/files which does something similar to this.

@TravisGM92
Copy link

@pranavrajs is it best practices to push up after I've written a test, to make sure I'm writing it correctly?

@pranavrajs
Copy link
Member Author

@TravisGM92 It is upto you, you can push the changes and put it draft mode. Once you create the PR, you would be able to see the diff coverage which should be helpful to figure out missing test cases.

@TravisGM92
Copy link

@pranavrajs Oh yeah I guess I meant for this specific issue. So we haven't created an activity message for when an agent mutes, so I wrote the test first and it should fail because we haven't made that feature yet.

@pranavrajs
Copy link
Member Author

@TravisGM92 Yeah, that is correct.

@TravisGM92
Copy link

@pranavrajs So I recognize a lot of what's going on in here but I'm having trouble understanding where to start. I understand writing the test, but I tried copying what the example you sent me above did to no avail. Any chance you'd be willing to point me in the right direction? If not I understand, I can un-assign myself

@pranavrajs
Copy link
Member Author

@TravisGM92 I don't understand the problem you mentioned, can provide me a little bit more context on what you are trying to achieve?

@TravisGM92
Copy link

@pranavrajs I'm just having trouble getting started on this issue. Not sure where to start

@yihyang
Copy link
Contributor

yihyang commented Oct 29, 2020

Hi @pranavrajs I have created a PR in #1373

Feel free to let me know what should I update, thanks

@pranavrajs pranavrajs added this to the v1.10.0 (HacktoberFest) milestone Oct 30, 2020
@pranavrajs
Copy link
Member Author

pranavrajs commented Oct 30, 2020

Fixed via #1373

@github-actions
Copy link

github-actions bot commented Aug 9, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backend Changes related to backend / ruby code Good first issue If you are new and looking to contribute hacktoberfest Issues to work during hacktoberfest
Projects
None yet
Development

No branches or pull requests

3 participants