Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "Rubocop/Metrics/AbcSize" issue in app/controllers/passwords_controller.rb #52

Closed
pranavrajs opened this issue Oct 2, 2019 · 4 comments
Closed

Fix "Rubocop/Metrics/AbcSize" issue in app/controllers/passwords_controller.rb #52

pranavrajs opened this issue Oct 2, 2019 · 4 comments
Labels
hacktoberfest Issues to work during hacktoberfest

Comments

@pranavrajs
Copy link
Member

Assignment Branch Condition size for set_headers is too high. [25.71/15]

https://codeclimate.com/github/chatwoot/chatwoot/app/controllers/passwords_controller.rb#issue_5d87480b87cf190001000335
@pranavrajs pranavrajs added codeclimate hacktoberfest Issues to work during hacktoberfest labels Oct 2, 2019
@jash-kothari
Copy link

Can i pick this up?

@pranavrajs
Copy link
Member Author

@jash-kothari Please go ahead, assign this issue to yourself and please start working on it, if you are interested.

Please read the contributing guide as well. https://github.com/chatwoot/chatwoot/blob/master/docs/contributing.md

@AlexisChavez97
Copy link
Contributor

Is this still open?

pranavrajs added a commit that referenced this issue Oct 22, 2019
@pranavrajs
Revert "Fix #52 rubocop metrics abc size in passwords controller (#119)"
175cd82 
This reverts commit 9c22da0.
pranavrajs added a commit that referenced this issue Oct 22, 2019
@pranavrajs
Create util for apiLoadingStatus (#170)
e0d291c 
* Create util for apiLoadingStatus

* Revert "Fix #52 rubocop metrics abc size in passwords controller (#119)"

This reverts commit 9c22da0.
@DiponRoy DiponRoy mentioned this issue Mar 31, 2021
Closed
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
hacktoberfest Issues to work during hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pranavrajs @jash-kothari @AlexisChavez97