Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Control rendering contact inbox #1157

Merged
merged 3 commits into from Aug 19, 2020
Merged

Conversation

sojan-official
Copy link
Member

Pull Request Template

Description

Remove rendering contact inboxes in unnecessary places.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@pr-triage pr-triage bot added the PR: unreviewed This pull request is yet to be reviewed. label Aug 19, 2020
pranavrajs
pranavrajs previously approved these changes Aug 19, 2020
@pr-triage pr-triage bot added PR: reviewed-approved All reviewers have approved the PR and removed PR: unreviewed This pull request is yet to be reviewed. labels Aug 19, 2020
@pr-triage pr-triage bot added PR: unreviewed This pull request is yet to be reviewed. and removed PR: reviewed-approved All reviewers have approved the PR labels Aug 19, 2020
@pr-triage pr-triage bot added PR: reviewed-approved All reviewers have approved the PR and removed PR: unreviewed This pull request is yet to be reviewed. labels Aug 19, 2020
@pranavrajs pranavrajs merged commit 507b40a into develop Aug 19, 2020
@pranavrajs pranavrajs deleted the chore/minor-fixes branch August 19, 2020 17:55
@pr-triage pr-triage bot added PR: merged The pull request is merged to another branch and removed PR: reviewed-approved All reviewers have approved the PR labels Aug 19, 2020
smshuja pushed a commit to smshuja/chatwoot that referenced this pull request Feb 2, 2021
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR: merged The pull request is merged to another branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants