Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add blank check for file param in Import API #3057

Merged
merged 2 commits into from
Sep 21, 2021
Merged

fix: Add blank check for file param in Import API #3057

merged 2 commits into from
Sep 21, 2021

Conversation

murtaza-bagwala
Copy link
Contributor

Description

Fix for Contact Imports API, it returns 200 success even if there is no file attached in the request

Fixes #3031

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue).

How Has This Been Tested?

Tried passing import_file param as nil in request payload and verified it.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective
  • New and existing unit tests pass locally with my changes

@pr-triage pr-triage bot added the PR: unreviewed This pull request is yet to be reviewed. label Sep 20, 2021
pranavrajs
pranavrajs previously approved these changes Sep 20, 2021
View reviewed changes
Copy link
Member

@pranavrajs pranavrajs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thanks for the PR. I have a small suggestion. Let us get this merged once that is done.

@pr-triage pr-triage bot added PR: reviewed-approved All reviewers have approved the PR and removed PR: unreviewed This pull request is yet to be reviewed. labels Sep 20, 2021
@pr-triage pr-triage bot added PR: unreviewed This pull request is yet to be reviewed. and removed PR: reviewed-approved All reviewers have approved the PR labels Sep 20, 2021
@pranavrajs pranavrajs changed the title add blank check for file fix: Add blank check for file param in Import API Sep 20, 2021
pranavrajs
pranavrajs approved these changes Sep 20, 2021
View reviewed changes
Copy link
Member

@pranavrajs pranavrajs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @sojan-official Can you please take a look and get this merged?

@pr-triage pr-triage bot added PR: reviewed-approved All reviewers have approved the PR and removed PR: unreviewed This pull request is yet to be reviewed. labels Sep 20, 2021
@pranavrajs pranavrajs merged commit c504067 into chatwoot:develop Sep 21, 2021
@pr-triage pr-triage bot added PR: merged The pull request is merged to another branch and removed PR: reviewed-approved All reviewers have approved the PR labels Sep 21, 2021
@github-actions
Copy link

github-actions bot commented Aug 9, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pranavrajs pranavrajs pranavrajs approved these changes

Assignees

@sojan-official sojan-official

Labels
PR: merged The pull request is merged to another branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Import API should throw an error if there is no valid file
3 participants
@murtaza-bagwala @pranavrajs @sojan-official