New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to reset password of agents to Admin #351
Add option to reset password of agents to Admin #351
Conversation
@pranavrajs please help review. Please let me know if I have not followed any convention of the Frontend App. |
Name: puma A poorly-behaved client could use keepalive requests to monopolize Puma's If more keepalive connections to Puma are opened than there are threads Solution: upgrade to ~> 3.12.2, >= 4.3.1 Vulnerabilities found! @pranavrajs @sojan-official how can I fix this? |
@mukesh4139 let's do a bundle update. |
#352 will fix this. |
…_reset_for_agents
…_reset_for_agents
this.editAgentsApi.message = this.$t('AGENT_MGMT.EDIT.PASSWORD_RESET.SUCCESS_MESSAGE'); | ||
this.showAlert(); | ||
this.resetForm(); | ||
setTimeout(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we use setTimeouts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to close the EditAgent popup after 10 ms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mukesh4139 I don't think we need to close the Popup on successful reset.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see the inline comment
…_reset_for_agents
@mukesh4139 Could you please post a screenshot/screencast if possible? That will make reviews easier. |
@pranavrajs you can view the recording here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks a lot for the contribution ❤️
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Pull Request Template
Description
Add ability to admin to send reset password for agents.
Covers #348
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I have tested this manually.
Checklist: