Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to reset password of agents to Admin #351

Conversation

mukesh4139
Copy link
Contributor

Pull Request Template

Description

Add ability to admin to send reset password for agents.
Covers #348

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

I have tested this manually.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@mukesh4139
Copy link
Contributor Author

@pranavrajs please help review.

Please let me know if I have not followed any convention of the Frontend App.

@mukesh4139
Copy link
Contributor Author

Name: puma
Version: 4.3.0
Advisory: CVE-2019-16770
Criticality: High
URL: GHSA-7xx3-m584-x994
Description:

A poorly-behaved client could use keepalive requests to monopolize Puma's
reactor and create a denial of service attack.

If more keepalive connections to Puma are opened than there are threads
available, additional connections will wait permanently if the attacker sends
requests frequently enough.

Solution: upgrade to ~> 3.12.2, >= 4.3.1

Vulnerabilities found!

@pranavrajs @sojan-official how can I fix this?

@sojan-official
Copy link
Member

@mukesh4139 let's do a bundle update.

@sojan-official
Copy link
Member

#352 will fix this.

this.editAgentsApi.message = this.$t('AGENT_MGMT.EDIT.PASSWORD_RESET.SUCCESS_MESSAGE');
this.showAlert();
this.resetForm();
setTimeout(() => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we use setTimeouts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to close the EditAgent popup after 10 ms.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mukesh4139 I don't think we need to close the Popup on successful reset.

Copy link
Member

@pranavrajs pranavrajs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the inline comment

@pranavrajs
Copy link
Member

@mukesh4139 Could you please post a screenshot/screencast if possible? That will make reviews easier.

@mukesh4139
Copy link
Contributor Author

Copy link
Member

@sojan-official sojan-official left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot for the contribution ❤️

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants