Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Fixes irregular padding on agent selector in report page #3593

Merged
merged 3 commits into from Dec 16, 2021
Merged

bug: Fixes irregular padding on agent selector in report page #3593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d84f7e7
bug: Fixes irregular padding on agent selector in report page
iamsivin Dec 16, 2021
03951a1
code climate fixes
iamsivin Dec 16, 2021
00834d5
Merge branch 'develop' into bug/report-agent-selector
iamsivin Dec 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions app/javascript/dashboard/assets/scss/plugins/_multiselect.scss
View file
Open in desktop
Expand Up @@ -51,6 +51,10 @@
width: 100%;
}

p {
margin-bottom: 0;
}

&.multiselect__option--highlight {
background: var(--white);
color: var(--color-body);
Expand Down
3 changes: 2 additions & 1 deletion app/javascript/dashboard/assets/scss/widgets/_reports.scss
View file
Open in desktop
Expand Up @@ -21,6 +21,7 @@
border: 1px solid var(--color-border);
}

.display-flex {
.reports-option__wrap {
align-items: center;
display: flex;
}
8 changes: 4 additions & 4 deletions app/javascript/dashboard/routes/dashboard/settings/reports/components/ReportFilters.vue
View file
Open in desktop
Expand Up @@ -15,7 +15,7 @@
@input="changeFilterSelection"
>
<template slot="singleLabel" slot-scope="props">
<div class="display-flex">
<div class="reports-option__wrap">
<thumbnail
src="props.option.thumbnail"
:username="props.option.name"
Expand All @@ -28,7 +28,7 @@
</div>
</template>
<template slot="option" slot-scope="props">
<div class="display-flex">
<div class="reports-option__wrap">
<thumbnail
src="props.option.thumbnail"
:username="props.option.name"
Expand All @@ -55,7 +55,7 @@
@input="changeFilterSelection"
>
<template slot="singleLabel" slot-scope="props">
<div class="display-flex">
<div class="reports-option__wrap">
<div
:style="{ backgroundColor: props.option.color }"
class="reports-option__rounded--item margin-right-small"
Expand All @@ -68,7 +68,7 @@
</div>
</template>
<template slot="option" slot-scope="props">
<div class="display-flex">
<div class="reports-option__wrap">
<div
:style="{ backgroundColor: props.option.color }"
class="
Expand Down