Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: non-zero exit on --logs and handle no opts #5006

Merged
merged 3 commits into from Jul 8, 2022

Conversation

vishnu-narayanan
Copy link
Member

Pull Request Template

Description

fix: non-zero exit on --logs and handle no opts

Fixes #4982

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Tested manually on an ec2 instance.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@pr-triage pr-triage bot added the PR: unreviewed This pull request is yet to be reviewed. label Jul 8, 2022
@vishnu-narayanan vishnu-narayanan merged commit 1bb9556 into develop Jul 8, 2022
@vishnu-narayanan vishnu-narayanan deleted the feat/cwctl_improvements branch July 8, 2022 13:19
@pr-triage pr-triage bot added PR: merged The pull request is merged to another branch and removed PR: unreviewed This pull request is yet to be reviewed. labels Jul 8, 2022
@github-actions
Copy link

github-actions bot commented Aug 8, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR: merged The pull request is merged to another branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chatwoot ctl improvements
1 participant