feat: Execute macro actions, for the conversation

[tejaswinichile]

Pull Request Template

Description

Execute macros actions for the conversation.

Fixes #5013

Type of change

Please delete options that are not relevant.

• New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested on local and with test cases.

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented on my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

Screen.Recording.2022-07-20.at.1.17.00.PM.mov

[sojan-official]

@tejaswinichile, unlike automation performed by the system, for macros, the actions should come under the agent who performed the action. Think of it as a sequence of actions that you perform as an agent everyday, so that you want that to be done in one click.

Also, for the macros endpoint, we will need to accept an array of conversation ids if we are thinking about having it in bulk actions.

cc: @pranavrajs

[pranavrajs]

@sojan-official Yes, this is correct. The user context should be used. Unlike automation, the action is performed by the agent, so every action should consider the user context (e.g., A message should be sent in the name of the agent, or labels should have the agent name, etc.). Also, we need support for multiple conversation ids in the API.

@tejaswinichile Noticed that the add_label action didn't work in the screencast.

[tejaswinichile]

@tejaswinichile Noticed that the add_label action didn't work in the screencast.

@pranavrajs Yeah because I didn't have those labels added to my account, it works, let me add the updated video.

Also, for the macros endpoint, we will need to accept an array of conversation ids if we are thinking about having it in bulk actions.

@pranavrajs @sojan-official Should I update the PR for the bulk actions?

The user context should be used. Unlike automation, the action is performed by the agent, so every action should consider the user context

Updating it. I added the Macro as a performer.

[tejaswinichile]

Screen.Recording.2022-07-20.at.10.39.12.PM.mov

Hey, @pranavrajs @sojan-official Please have a look at this updated video.

[pranavrajs]

@pranavrajs @sojan-official Should I update the PR for the bulk actions?

I guess you can update the conversation_id parameter in the API to use conversation_ids.

[sojan-official]

Added a couple of comments. Looks good overall.

[sojan-official]

let's use Current.user instead. We are trying to remove the usage current_user in favor of this.

[sojan-official]

some of these methods seem repetitive to what we have in automation service

chatwoot/app/services/automation_rules/action_service.rb

Line 101 in c4b2005

def agent_belongs_to_account?(agent_ids)

can we extract them to a common base class or a helper and avoid the repetition?

[tejaswinichile]

Yes, we can have a common action service may be. The issue was just with the activity execution, let me check.

[tejaswinichile]

@sojan-official This has been fixed please have a look.

[sojan-official]

LGTM

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.