Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update browser_language logic to include all languages #5090

Merged
merged 2 commits into from Jul 22, 2022
Merged

fix: Update browser_language logic to include all languages #5090

merged 2 commits into from Jul 22, 2022

Conversation

pranavrajs
Copy link
Member

  • Add missing attribute in additional_attributes
  • Display browser_language in the sidebar.
  • Update the language list to use everything.

@pr-triage pr-triage bot added the PR: unreviewed This pull request is yet to be reviewed. label Jul 22, 2022
pranavrajs
pranavrajs commented Jul 22, 2022
View reviewed changes
app/javascript/dashboard/components/widgets/conversation/advancedFilterItems/languages.js
},
{
name: 'Zulu',
id: 'zu',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Display all the languages in ISO 639 list.

tejaswinichile
tejaswinichile previously approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@tejaswinichile tejaswinichile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@pr-triage pr-triage bot added PR: partially-approved Not all reviewers have approved the PR and removed PR: unreviewed This pull request is yet to be reviewed. labels Jul 22, 2022
@pr-triage pr-triage bot added PR: unreviewed This pull request is yet to be reviewed. and removed PR: partially-approved Not all reviewers have approved the PR labels Jul 22, 2022
@pranavrajs pranavrajs merged commit 32291f4 into develop Jul 22, 2022
@pranavrajs pranavrajs deleted the fix/browser-language-issue branch July 22, 2022 07:44
@pr-triage pr-triage bot added PR: merged The pull request is merged to another branch and removed PR: unreviewed This pull request is yet to be reviewed. labels Jul 22, 2022
WevrLabs added a commit to WevrLabs/chatwoot that referenced this pull request Jul 22, 2022
@WevrLabs
Squashed commit of the following:
8346ef5 
commit a946c06
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Fri Jul 22 11:41:14 2022 +0200

    chore(deps): bump terser from 4.8.0 to 4.8.1 (chatwoot#5069)

    Bumps [terser](https://github.com/terser/terser) from 4.8.0 to 4.8.1.
    - [Release notes](https://github.com/terser/terser/releases)
    - [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md)
    - [Commits](https://github.com/terser/terser/commits)

    ---
    updated-dependencies:
    - dependency-name: terser
      dependency-type: indirect
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit bc3e7d2
Author: Kyle McLaren <kylemclaren@protonmail.com>
Date:   Fri Jul 22 11:39:37 2022 +0200

    chore: Support for Elastic APM (chatwoot#5004)

    This PR adds support for Elastic APM for APM and Tracing in self-hosted installations.
    Configuration can be done via the ELASTIC_APM_SERVER_URL and ELASTIC_APM_SECRET_TOKEN env variables.

    fixes: chatwoot#4999

commit 5727928
Author: Tejaswini Chile <tejaswini@chatwoot.com>
Date:   Fri Jul 22 15:01:07 2022 +0530

    fix: help center clearing minor bugs (chatwoot#5075)

commit 32291f4
Author: Pranav Raj S <pranav@chatwoot.com>
Date:   Fri Jul 22 13:14:17 2022 +0530

    fix: Update browser_language logic to include all languages (chatwoot#5090)

commit 6a6a37a
Author: Sojan Jose <sojan@pepalo.com>
Date:   Thu Jul 21 19:27:12 2022 +0200

    chore: Ability to Disable Gravatars (chatwoot#5027)

    fixes: chatwoot#3853

    - Introduced DISABLE_GRAVATAR Global Config, which will stop chatwoot from making API requests to gravatar
    - Cleaned up avatar-related logic and centralized it into the avatarable concern
    - Added specs for the missing cases
    - Added migration for existing installations to move the avatar to attachment, rather than making the API that results in 404.
WevrLabs added a commit to WevrLabs/chatwoot that referenced this pull request Jul 24, 2022
@WevrLabs
Squashed commit of the following:
b7db975 
commit ffec427
Author: Tejaswini Chile <tejaswini@chatwoot.com>
Date:   Fri Jul 22 15:37:24 2022 +0530

    fix: mention notification mail for empty contact name (chatwoot#5091)

commit 8acba37
Author: Sojan Jose <sojan@pepalo.com>
Date:   Fri Jul 22 11:46:31 2022 +0200

    chore: Add specs for stripe Webhooks endpoint (chatwoot#5087)

commit a946c06
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Fri Jul 22 11:41:14 2022 +0200

    chore(deps): bump terser from 4.8.0 to 4.8.1 (chatwoot#5069)

    Bumps [terser](https://github.com/terser/terser) from 4.8.0 to 4.8.1.
    - [Release notes](https://github.com/terser/terser/releases)
    - [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md)
    - [Commits](https://github.com/terser/terser/commits)

    ---
    updated-dependencies:
    - dependency-name: terser
      dependency-type: indirect
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit bc3e7d2
Author: Kyle McLaren <kylemclaren@protonmail.com>
Date:   Fri Jul 22 11:39:37 2022 +0200

    chore: Support for Elastic APM (chatwoot#5004)

    This PR adds support for Elastic APM for APM and Tracing in self-hosted installations.
    Configuration can be done via the ELASTIC_APM_SERVER_URL and ELASTIC_APM_SECRET_TOKEN env variables.

    fixes: chatwoot#4999

commit 5727928
Author: Tejaswini Chile <tejaswini@chatwoot.com>
Date:   Fri Jul 22 15:01:07 2022 +0530

    fix: help center clearing minor bugs (chatwoot#5075)

commit 32291f4
Author: Pranav Raj S <pranav@chatwoot.com>
Date:   Fri Jul 22 13:14:17 2022 +0530

    fix: Update browser_language logic to include all languages (chatwoot#5090)

commit 6a6a37a
Author: Sojan Jose <sojan@pepalo.com>
Date:   Thu Jul 21 19:27:12 2022 +0200

    chore: Ability to Disable Gravatars (chatwoot#5027)

    fixes: chatwoot#3853

    - Introduced DISABLE_GRAVATAR Global Config, which will stop chatwoot from making API requests to gravatar
    - Cleaned up avatar-related logic and centralized it into the avatarable concern
    - Added specs for the missing cases
    - Added migration for existing installations to move the avatar to attachment, rather than making the API that results in 404.
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tejaswinichile tejaswinichile tejaswinichile left review comments

@sojan-official sojan-official Awaiting requested review from sojan-official

Assignees

@tejaswinichile tejaswinichile

Labels
PR: merged The pull request is merged to another branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pranavrajs @tejaswinichile