New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update data format for platform API feature management #5718
chore: Update data format for platform API feature management #5718
Conversation
@sojan-official @pranavrajs can you please merge this is enhancement for remaining feature flag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new format looks good to me and seems more versatile.
Added a comment on the patch request. lets process to merge once that is resolved.
…flags-false' into chore/accounts-api-with-feature-flags-false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am done with the requested changes.
I am done with the changes in patch request test spec. |
@smartdev58, thanks a lot for the changes. I have slightly refactored the logic so that the behaviour is consistent for creation and update. With this change, the currently enabled features in an account or features enabled through installation configuration are not affected unless the feature key is explicitly mentioned in features params.
|
Updated JSON data format for Platform API for account creation update API endpoints features flags to accept false values on each feature. fixes: #5717
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
Updated json data format for Platform API for account creation update API endpoints features flags to accept false values on each feature. #5717
Fixes # (issue)
Type of change
How Has This Been Tested?
https://www.loom.com/share/b0d9452d556f41738924239cba080e92
Checklist: