Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update data format for platform API feature management #5718

Conversation

smartdev58
Copy link
Contributor

@smartdev58 smartdev58 commented Oct 23, 2022

Description

Updated json data format for Platform API for account creation update API endpoints features flags to accept false values on each feature. #5717

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

https://www.loom.com/share/b0d9452d556f41738924239cba080e92

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@pr-triage pr-triage bot added the PR: unreviewed This pull request is yet to be reviewed. label Oct 23, 2022
@voko3456
Copy link

@sojan-official @pranavrajs can you please merge this is enhancement for remaining feature flag

@vishnu-narayanan vishnu-narayanan requested review from a team, pranavrajs and tejaswinichile and removed request for a team November 2, 2022 08:32
Copy link
Member

@sojan-official sojan-official left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new format looks good to me and seems more versatile.
Added a comment on the patch request. lets process to merge once that is resolved.

@pr-triage pr-triage bot added PR: reviewed-changes-requested Some / all of the reviewers have requested for changes and removed PR: unreviewed This pull request is yet to be reviewed. labels Nov 3, 2022
@pr-triage pr-triage bot added PR: unreviewed This pull request is yet to be reviewed. and removed PR: reviewed-changes-requested Some / all of the reviewers have requested for changes labels Nov 3, 2022
Copy link
Contributor Author

@smartdev58 smartdev58 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am done with the requested changes.

@smartdev58
Copy link
Contributor Author

The new format looks good to me and seems more versatile. Added a comment on the patch request. lets process to merge once that is resolved.

I am done with the changes in patch request test spec.

@sojan-official
Copy link
Member

@smartdev58, thanks a lot for the changes. I have slightly refactored the logic so that the behaviour is consistent for creation and update. With this change, the currently enabled features in an account or features enabled through installation configuration are not affected unless the feature key is explicitly mentioned in features params.

Example: 
Account 1 -> already has inbox_management / channel_facebook enabled
Patch /accounts/1  { features: {  inbox_management: false, channel_email: true } 

Based on the initial PR -> after the patch account will only have: channel_email to be true; the previously enabled channel_facebook is also used to get overwritten.

With the current changes: the account will have both channel_email and channel_facebook enabled after the patch.

@sojan-official sojan-official changed the title chore: data format updates for account creation & update api with features f… chore: Update data format for platform API feature management Nov 8, 2022
@sojan-official sojan-official merged commit b50890d into chatwoot:develop Nov 8, 2022
@pr-triage pr-triage bot added PR: merged The pull request is merged to another branch and removed PR: unreviewed This pull request is yet to be reviewed. labels Nov 8, 2022
tejaswinichile pushed a commit that referenced this pull request Nov 9, 2022
Updated JSON data format for Platform API for account creation update API endpoints features flags to accept false values on each feature. 

fixes: #5717
@github-actions
Copy link

github-actions bot commented Dec 8, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR: merged The pull request is merged to another branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants