Feat/5733 Add private note action in macros #5805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fayazara
approved these changes
Nov 7, 2022
There was a problem hiding this comment.
Looks good. Added a small update to resolve the notes in preview.
Tested locally - https://www.loom.com/share/2978fa2c6e434974b5a4d94ea791aef2
pr-triage
bot
added
PR: partially-approved
pr-triage
bot
added
PR: merged
pranavrajs
reviewed
Nov 7, 2022
Comment on lines
+25
to
+33
| def add_private_note(message) | ||
| return if conversation_a_tweet? | ||
|
|
||
| params = { content: message[0], private: true } | ||
|
|
||
| # Added reload here to ensure conversation us persistent with the latest updates | ||
| mb = Messages::MessageBuilder.new(@user, @conversation.reload, params) | ||
| mb.perform | ||
| end |
There was a problem hiding this comment.
@tejaswinichile Couldn't this be a common function for both send_message and private note?
pr-triage
bot
added
PR: partially-approved
tejaswinichile
added a commit
that referenced
this pull request
Nov 9, 2022
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5733
Type of change
How Has This Been Tested?
Tested on local, can save the macros with private note and when we execute the macros able to see private note in the conversation
Checklist: