chore: Update the widescreen layout button icon and background #6217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for chatwoot-storybook ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
fayazara
added
frontend
nithindavid
suggested changes
Jan 10, 2023
| > | ||
| <fluent-icon icon="panel-contract" :size="16" /> | ||
| </div> | ||
| <fluent-icon |
There was a problem hiding this comment.
<div>
<woot-button
v-tooltip.left="$t('CONVERSATION.SWITCH_VIEW_LAYOUT')"
icon="arrow-right-import"
size="tiny"
variant="smooth"
color-scheme="secondary"
class="layout-switch__container"
:class="{ expanded: isOnExpandedLayout }"
@click="toggle"
/>
</div>
Can we use woot-button here? Might need to change CSS for rotating the icon
There was a problem hiding this comment.
Can we use
woot-buttonhere? Might need to change CSS for rotating the icon
@nithindavid thought of using this, but using the rotate on the button itself would rotate the entire button instead of that icon
There was a problem hiding this comment.
@fayazara We could use this
&.expanded .icon {
transform: rotate(180deg);
}
There was a problem hiding this comment.
@nithindavid Updated, please have a look
pr-triage
bot
added
the
PR: reviewed-changes-requested
nithindavid
approved these changes
Jan 10, 2023
pr-triage
bot
added
the
PR: partially-approved
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current widescreen toggle button didn't match the other elements and was taking unnecessary space.
This uses a different icons, which I think makes more sense to use here.
Before
After