Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adds support on direction RTL in UI #6369

Closed
wants to merge 48 commits into from
Closed

feat: Adds support on direction RTL in UI #6369

wants to merge 48 commits into from

Conversation

iamsivin
Copy link
Member

@iamsivin iamsivin commented Feb 1, 2023 •
edited

Pull Request Template

Fixes #686

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

https://www.loom.com/share/53e305e7d58e4576ae6014c7dcc0554d

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@pr-triage pr-triage bot added the PR: draft The pull request is not ready to be reviewed label Feb 1, 2023
@netlify
Copy link

netlify bot commented Feb 1, 2023 •
edited

✅ Deploy Preview for chatwoot-storybook ready!

Name Link
🔨 Latest commit a4972c3
🔍 Latest deploy log https://app.netlify.com/sites/chatwoot-storybook/deploys/63f63769dedc3f000803e347
😎 Deploy Preview https://deploy-preview-6369--chatwoot-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@iamsivin iamsivin marked this pull request as ready for review February 8, 2023 10:00
@pr-triage pr-triage bot added PR: unreviewed This pull request is yet to be reviewed. and removed PR: draft The pull request is not ready to be reviewed labels Feb 8, 2023
scmmishra
scmmishra approved these changes Feb 20, 2023
View reviewed changes
Copy link
Member

@scmmishra scmmishra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving these changes, I would suggest testing it on staging once. From a code point of view, this seems good to go

@pr-triage pr-triage bot added PR: partially-approved Not all reviewers have approved the PR and removed PR: unreviewed This pull request is yet to be reviewed. labels Feb 20, 2023
@iamsivin
feat: Adds rtl related scss to a single file (#6458)
e07a937 
* feat: Adds rtl related scss to a single file

* chore: Back button fixes

* chore: Minor fixes

* chore: List article header title
@pr-triage pr-triage bot added PR: unreviewed This pull request is yet to be reviewed. and removed PR: partially-approved Not all reviewers have approved the PR labels Feb 20, 2023
nithindavid
nithindavid reviewed Feb 23, 2023
View reviewed changes
app/javascript/dashboard/components/CustomAttribute.vue
margin: 0 var(--space-smaller);

button {
border-radius: var(--border-radius-normal) !important;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rewrite rule

@iamsivin iamsivin marked this pull request as draft February 23, 2023 17:06
@iamsivin
Copy link
Member Author

Closing this PR as splitted this PR into multiples and merged to develop.
#6515, #6516, #6517, #6518, #6519, #6521, #6524, #6525, #6526, #6531, #6537

@iamsivin iamsivin closed this Feb 27, 2023
@pr-triage pr-triage bot added PR: draft The pull request is not ready to be reviewed and removed PR: unreviewed This pull request is yet to be reviewed. labels Feb 27, 2023
@iamsivin iamsivin deleted the feat/rtl-support branch February 27, 2023 14:59
@hadifarnoud
Copy link

cool. how can I try it locally?

@iamsivin
Copy link
Member Author

iamsivin commented Mar 1, 2023

cool. how can I try it locally?

@hadifarnoud You can try it locally in the latest develop branch.
Steps

  1. By going to account settings
  2. Change the language that supports RTL (supported language code - 'ar', 'as', 'fa', 'he', 'ku', 'ur')
  3. And update the settings. Then the direction will be changed.

@hadifarnoud
Copy link

what branch I should check out?

@iamsivin
Copy link
Member Author

iamsivin commented Mar 1, 2023

what branch I should check out?

You can test it in the default develop branch.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nithindavid nithindavid nithindavid left review comments

@scmmishra scmmishra scmmishra approved these changes

@pranavrajs pranavrajs Awaiting requested review from pranavrajs

@fayazara fayazara Awaiting requested review from fayazara

@muhsin-k muhsin-k Awaiting requested review from muhsin-k

Assignees

@nithindavid nithindavid

Labels
PR: draft The pull request is not ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Implement RTL language support
5 participants
@iamsivin @hadifarnoud @nithindavid @scmmishra @vishnu-narayanan