feat(poc): Disable widget based on country #6658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for chatwoot-storybook canceled.
|
pr-triage
bot
added
PR: partially-approved
sojan-official
approved these changes
Mar 14, 2023
Comment on lines
+2
to
+3
| web: bundle exec rails ip_lookup:setup && bin/rails server -p $PORT -e $RAILS_ENV | ||
| worker: bundle exec rails ip_lookup:setup && bundle exec sidekiq -C config/sidekiq.yml |
There was a problem hiding this comment.
We could trigger this from the initializer. It would ensure that it stays consistent across all installation environments with out updating the documentation.
There was a problem hiding this comment.
@sojan-official Can you please make the change if it is a small one?
pr-triage
bot
added
PR: reviewed-approved
pr-triage
bot
added
PR: merged
rutvijmehta-harness
pushed a commit
to rutvijmehta-harness/chatwoot
that referenced
this pull request
Mar 20, 2023
rutvijmehta-harness
added a commit
to rutvijmehta-harness/chatwoot
that referenced
this pull request
Mar 20, 2023
Co-authored-by: Pranav Raj S <pranav@chatwoot.com>
rutvijmehta-harness
pushed a commit
to rutvijmehta-harness/chatwoot
that referenced
this pull request
Mar 27, 2023
rutvijmehta-harness
added a commit
to rutvijmehta-harness/chatwoot
that referenced
this pull request
Mar 27, 2023
Co-authored-by: Pranav Raj S <pranav@chatwoot.com>
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.loom.com/share/f2363462485b4aa8a6826f77a8964bf7
Changes:
The database download has been moved to a rake task and will be downloaded during boot up. Dynamically fetching (async fetches via Sidekiq) the database does not work well with synchronous calls since each server requires a copy of the file.
I updated the Procfile to download the DB initially and then run the service afterwards. This change may increase the bootup time by 3-4 seconds, depending on network latency.
I removed the IP_LOOKUP_SERVICE variable because none of the other services will work without the lookup parameter. Therefore, managing this variable is pointless.