Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Renders youtube and vimeo links within blank lines as embeds #7422

Merged
merged 8 commits into from Sep 21, 2023

Conversation

nithindavid
Copy link
Contributor

Description

Within the article we are now rendering every link for youtube and vimeo as embeds. This isn't a good solution, as users might need to have plain links as well. This fix will render only links within two blank lines as embeds.

image image

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@netlify
Copy link

netlify bot commented Jun 28, 2023

Deploy Preview for chatwoot-storybook canceled.

Name Link
🔨 Latest commit bfad7e1
🔍 Latest deploy log https://app.netlify.com/sites/chatwoot-storybook/deploys/650be9ac19d3940009c05819

@github-actions
Copy link

github-actions bot commented Aug 5, 2023

🐢 Turtley slow progress alert! This pull request has been idle for over 30 days. Can we please speed things up and either merge it or release it back into the wild?

@github-actions github-actions bot added the stale label Aug 5, 2023
@github-actions github-actions bot removed the stale label Aug 15, 2023
@pranavrajs
Copy link
Member

@nithindavid Can you please suggest the next steps on this PR?

@pranavrajs pranavrajs added the PR: reviewed-changes-requested Some / all of the reviewers have requested for changes label Sep 4, 2023
@sojan-official
Copy link
Member

verified in local

Screenshot 2023-09-20 at 11 53 18 PM Screenshot 2023-09-20 at 11 53 13 PM

Copy link
Member

@sojan-official sojan-official left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sojan-official sojan-official merged commit 53dc38e into develop Sep 21, 2023
15 checks passed
@sojan-official sojan-official deleted the feat/embed-within-blank-lines branch September 21, 2023 07:16
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR: reviewed-changes-requested Some / all of the reviewers have requested for changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants