Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Agent name not visible in team page #7730

Merged
merged 2 commits into from
Aug 16, 2023
Merged

fix: Agent name not visible in team page #7730

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d50fb7a
fix: Agent name not visible in team page
iamsivin Aug 16, 2023
87c6b1b
Merge branch 'develop' into fix/CW-2399
sojan-official Aug 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
57 changes: 15 additions & 42 deletions app/javascript/dashboard/routes/dashboard/settings/teams/AgentSelector.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<thead>
<tr>
<td>
<div class="checkbox-wrap">
<div class="flex items-center">
<input
name="select-all-agents"
type="checkbox"
Expand All @@ -15,8 +15,12 @@
/>
</div>
</td>
<td>{{ $t('TEAMS_SETTINGS.AGENTS.AGENT') }}</td>
<td>{{ $t('TEAMS_SETTINGS.AGENTS.EMAIL') }}</td>
<td class=" text-slate-800 dark:text-slate-100">
{{ $t('TEAMS_SETTINGS.AGENTS.AGENT') }}
</td>
<td class=" text-slate-800 dark:text-slate-100">
{{ $t('TEAMS_SETTINGS.AGENTS.EMAIL') }}
</td>
</tr>
</thead>
<tbody>
Expand All @@ -25,8 +29,8 @@
:key="agent.id"
:class="agentRowClass(agent.id)"
>
<td class="checkbox-cell">
<div class="checkbox-wrap">
<td class="w-12">
<div class="flex items-center">
<input
type="checkbox"
:checked="isAgentSelected(agent.id)"
Expand All @@ -35,14 +39,14 @@
</div>
</td>
<td>
<div class="user-info-wrap">
<div class="flex items-center gap-2">
<thumbnail
:src="agent.thumbnail"
size="24px"
:username="agent.name"
:status="agent.availability_status"
/>
<h4 class="sub-block-title user-name">
<h4 class="text-base mb-0 text-slate-800 dark:text-slate-100">
{{ agent.name }}
</h4>
</div>
Expand All @@ -53,7 +57,7 @@
</tr>
</tbody>
</table>
<div class="add-agents__footer">
<div class="flex items-center justify-between">
<p>
{{
$t('TEAMS_SETTINGS.AGENTS.SELECTED_COUNT', {
Expand Down Expand Up @@ -141,39 +145,8 @@ export default {
};
</script>

<style scoped lang="scss">
.table__meta {
display: flex;
justify-content: space-between;
align-items: center;
padding: var(--space-small);
}

.user-info-wrap {
display: flex;
align-items: center;
}

.user-name {
margin-bottom: 0;
margin-left: var(--space-small);
}

.add-agents__footer {
display: flex;
align-items: center;
justify-content: space-between;
}

.checkbox-wrap {
display: flex;
align-items: center;

input {
margin: 0;
}
}
.checkbox-cell {
width: var(--space-larger);
<style scoped>
input {
@apply mb-0;
}
</style>
4 changes: 3 additions & 1 deletion app/javascript/dashboard/routes/dashboard/settings/teams/Create/AddAgents.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
<template>
<div class="wizard-body w-[75%] flex-shrink-0 flex-grow-0 max-w-[75%]">
<div
class="wizard-body w-[75%] flex-shrink-0 flex-grow-0 max-w-[75%] overflow-y-auto"
>
<form class="mx-0 flex flex-wrap" @submit.prevent="addAgents">
<div class="w-full">
<page-header
Expand Down