Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix an issue where Tag Agents is appearing above the Profile Menu. #7743

Merged
merged 3 commits into from Aug 17, 2023

Conversation

LiamAshdown
Copy link
Contributor

@LiamAshdown LiamAshdown commented Aug 16, 2023

Fixes an issue where Tag Agents is appearing above the Profile Menu.
Screenshot 2023-08-16 at 23 48 41

Fixes #7742

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

By triggering the Tag Agent menu and then opening up the Profile Menu.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code=
  • My changes generate no new warnings=

@netlify
Copy link

netlify bot commented Aug 16, 2023

Deploy Preview for chatwoot-storybook ready!

Name Link
🔨 Latest commit 9ce8a19
🔍 Latest deploy log https://app.netlify.com/sites/chatwoot-storybook/deploys/64ddd610738898000839d371
😎 Deploy Preview https://deploy-preview-7743--chatwoot-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -3,7 +3,7 @@
<div
v-if="show"
v-on-clickaway="onClickAway"
class="left-3 rtl:left-auto rtl:right-3 bottom-16 w-64 absolute z-20 rounded-md shadow-xl bg-white dark:bg-slate-800 py-2 px-2 border border-slate-25 dark:border-slate-700"
class="left-3 rtl:left-auto rtl:right-3 bottom-16 w-64 absolute z-[30] rounded-md shadow-xl bg-white dark:bg-slate-800 py-2 px-2 border border-slate-25 dark:border-slate-700"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LiamAshdown Instead of z-[30] can we use as z-30

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamsivin Done :)

Copy link
Member

@iamsivin iamsivin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving this pull request as it looks good to me.

@muhsin-k muhsin-k self-requested a review August 17, 2023 10:15
@pranavrajs pranavrajs merged commit 961c911 into chatwoot:develop Aug 17, 2023
17 checks passed
rutvijmehta-harness pushed a commit to rutvijmehta-harness/chatwoot that referenced this pull request Aug 29, 2023
rutvijmehta-harness added a commit to rutvijmehta-harness/chatwoot that referenced this pull request Aug 29, 2023
…ile menu (chatwoot#7743) (#325)

Co-authored-by: Liam <43280985+LiamAshdown@users.noreply.github.com>
rutvijmehta-harness pushed a commit to rutvijmehta-harness/chatwoot that referenced this pull request Aug 30, 2023
rutvijmehta-harness added a commit to rutvijmehta-harness/chatwoot that referenced this pull request Aug 30, 2023
…ile menu (chatwoot#7743) (#359)

Co-authored-by: Liam <43280985+LiamAshdown@users.noreply.github.com>
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tag Agents appearing above Profile Menu
4 participants