Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Contact import improvements #7787

Merged
merged 4 commits into from Aug 24, 2023
Merged

Conversation

sojan-official
Copy link
Member

@sojan-official sojan-official commented Aug 23, 2023

  • Ensure existing contact information is updated on data import
  • Refactor the existing job to make it more readable
  • Fixes issues with import files in wrong encoding

fixes: #7307

@netlify
Copy link

netlify bot commented Aug 23, 2023

Deploy Preview for chatwoot-storybook canceled.

Name Link
🔨 Latest commit 6fff5fa
🔍 Latest deploy log https://app.netlify.com/sites/chatwoot-storybook/deploys/64e6f160498df30008d80436

@sojan-official
Copy link
Member Author

  • verified in local

@sojan-official sojan-official merged commit acb7deb into develop Aug 24, 2023
17 checks passed
@sojan-official sojan-official deleted the chore/fix-contact-import branch August 24, 2023 06:24
sojan-official added a commit that referenced this pull request Aug 24, 2023
The previous fix would remove emojis in contact data. This change ensures they are persisited

ref: #7787
@sentry-io
Copy link

sentry-io bot commented Aug 25, 2023

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ActiveStorage::FileNotFoundError: ActiveStorage::FileNotFoundError (ActiveStorage::FileNotFoundError) Sidekiq/DataImportJob View Issue

Did you find this useful? React with a 👍 or 👎

rutvijmehta-harness pushed a commit to rutvijmehta-harness/chatwoot that referenced this pull request Aug 30, 2023
- Ensure existing contact information is updated on data import
- Refactor the existing job to make it more readable
- Fixes issues with import files in the wrong encoding
fixes: chatwoot#7307
rutvijmehta-harness added a commit to rutvijmehta-harness/chatwoot that referenced this pull request Aug 30, 2023
- Ensure existing contact information is updated on data import
- Refactor the existing job to make it more readable
- Fixes issues with import files in the wrong encoding
fixes: chatwoot#7307

Co-authored-by: Sojan Jose <sojan@pepalo.com>
rutvijmehta-harness pushed a commit to rutvijmehta-harness/chatwoot that referenced this pull request Aug 30, 2023
The previous fix would remove emojis in contact data. This change ensures they are persisited

ref: chatwoot#7787
rutvijmehta-harness added a commit to rutvijmehta-harness/chatwoot that referenced this pull request Aug 30, 2023
The previous fix would remove emojis in contact data. This change ensures they are persisited

ref: chatwoot#7787

Co-authored-by: Sojan Jose <sojan@pepalo.com>
rutvijmehta-harness pushed a commit to rutvijmehta-harness/chatwoot that referenced this pull request Aug 31, 2023
- Ensure existing contact information is updated on data import
- Refactor the existing job to make it more readable
- Fixes issues with import files in the wrong encoding
fixes: chatwoot#7307
rutvijmehta-harness added a commit to rutvijmehta-harness/chatwoot that referenced this pull request Aug 31, 2023
- Ensure existing contact information is updated on data import
- Refactor the existing job to make it more readable
- Fixes issues with import files in the wrong encoding
fixes: chatwoot#7307

Co-authored-by: Sojan Jose <sojan@pepalo.com>
rutvijmehta-harness pushed a commit to rutvijmehta-harness/chatwoot that referenced this pull request Aug 31, 2023
The previous fix would remove emojis in contact data. This change ensures they are persisited

ref: chatwoot#7787
rutvijmehta-harness added a commit to rutvijmehta-harness/chatwoot that referenced this pull request Aug 31, 2023
The previous fix would remove emojis in contact data. This change ensures they are persisited

ref: chatwoot#7787

Co-authored-by: Sojan Jose <sojan@pepalo.com>
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import CSV on the contacts page is not working properly
1 participant