fix: Fixes error in ChatList component #8266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for chatwoot-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nithindavid
commented
Oct 31, 2023
| @@ -410,8 +410,10 @@ export default { | |||
| }, | |||
| conversationListPagination() { | |||
| const conversationsPerPage = 25; | |||
| const hasChatsOnView = | |||
There was a problem hiding this comment.
@iamsivin Can you check if this is the same since arrays cannot be explicitly compared this.chatsOnView !== []
There was a problem hiding this comment.
@nithindavid This change will introduce the same bug there was before. https://linear.app/chatwoot/issue/CW-1424/pagination-not-working-properly
iamsivin
reviewed
Nov 1, 2023
Co-authored-by: Sivin Varghese <64252451+iamsivin@users.noreply.github.com>
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Checklist: