Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support_email and inbound_email_domain returning empty string #8963

Merged
merged 1 commit into from Feb 19, 2024

Conversation

sojan-official
Copy link
Member

  • While debugging a prod issue, we notified that if someone enabled custom_reply_email' or custom_reply_emailemail features and updated their account. The account's values for attributesdomainandsupport_email` will change to "" instead of nil, which causes issues with email sending. Hence adding appropriate fixes for the same.

Copy link
Member

@vishnu-narayanan vishnu-narayanan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vishnu-narayanan vishnu-narayanan merged commit 978a8a4 into develop Feb 19, 2024
14 checks passed
@vishnu-narayanan vishnu-narayanan deleted the chore/email-fixes branch February 19, 2024 10:13
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants