Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adds steps to show onboarding view after signup #8966

Merged
merged 6 commits into from
Mar 4, 2024
Merged

feat: Adds steps to show onboarding view after signup #8966

merged 6 commits into from
Mar 4, 2024

Conversation

nithindavid
Copy link
Contributor

@nithindavid nithindavid commented Feb 19, 2024 •
edited
Loading

Description

Loom - https://www.loom.com/share/fbbef49e372c47d580f8f8ffdcbd8664?sid=62511b6d-1d41-4fe5-b107-dbcac45b6677

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@nithindavid nithindavid marked this pull request as ready for review February 19, 2024 17:06
@nithindavid nithindavid changed the base branch from develop to feat/onboarding-cw-2667 March 3, 2024 09:34
nithindavid and others added 3 commits March 3, 2024 01:34
@nithindavid
Merge branch 'feat/onboarding-cw-2667' into feat/onboarding-steps
94e6437
@nithindavid @iamsivin
chore: Adds helpers needed for onboarding views (#8937)
c1c9469 
* chore: Adds helpers needed for onboarding views

* Update OnboardingHelper.js

* Update OnboardingHelper.spec.js

* Update BrowserHelper.spec.js

* Update app/javascript/v3/helpers/BrowserHelper.js

Co-authored-by: Sivin Varghese <64252451+iamsivin@users.noreply.github.com>

* Update app/javascript/v3/helpers/OnboardingHelper.js

Co-authored-by: Sivin Varghese <64252451+iamsivin@users.noreply.github.com>

* Updates helper

* Update app/javascript/dashboard/constants/globals.js

* Update app/javascript/v3/helpers/BrowserHelper.js

* Update app/javascript/v3/helpers/specs/BrowserHelper.spec.js

* Adds case for handling empty values

* Lint error fixes

---------

Co-authored-by: Sivin Varghese <64252451+iamsivin@users.noreply.github.com>
@nithindavid
Merge branch 'feat/onboarding-cw-2667' into feat/onboarding-steps
46fe9dd
@nithindavid nithindavid merged commit b9d177b into feat/onboarding-cw-2667 Mar 4, 2024
2 of 6 checks passed
@nithindavid nithindavid deleted the feat/onboarding-steps branch March 4, 2024 10:33
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pranavrajs pranavrajs Awaiting requested review from pranavrajs pranavrajs is a code owner

Assignees

@nithindavid nithindavid

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@nithindavid