Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add filter status=all to conversation list and meta #8994

Merged

Conversation

danilofuchs
Copy link
Contributor

Pull Request Template

Description

The code skips filtering if status=all in the query params, but the documentation was out of date:

https://github.com/SalvyLTD/chatwoot/blob/3fec1e195e3c4f5e3d41e6180f0b96d07de40e72/app/finders/conversation_finder.rb#L130

Closes #8993

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@pranavrajs
Copy link
Member

@danilofuchs Thanks for the PR. This is helpful. However, you need to edit this someplace else. Please see the screenshot below.

Screenshot 2024-02-22 at 3 24 20 PM

swagger.json is a generated file. You would have to run rake swagger:build once you make changes to the files as mentioned above.

Please see the guide here. https://www.chatwoot.com/hc/handbook/articles/swagger-documentation-31

If I had edit permission, I could have done that myself. For some reason, I cannot push to this branch.

@pranavrajs pranavrajs self-assigned this Feb 22, 2024
@pranavrajs pranavrajs added the PR: reviewed-changes-requested Some / all of the reviewers have requested for changes label Feb 22, 2024
Copy link
Member

@pranavrajs pranavrajs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the comment above.

@pranavrajs pranavrajs added the community PRs from the community label Feb 23, 2024
@vishnu-narayanan vishnu-narayanan temporarily deployed to chatwoot-pr-8994 February 26, 2024 20:47 Inactive
@danilofuchs
Copy link
Contributor Author

@pranavrajs
I believe this is now corrected

@pranavrajs
Copy link
Member

Great, thanks! Merging it now.

@pranavrajs pranavrajs merged commit fd993fe into chatwoot:develop Feb 26, 2024
12 of 13 checks passed
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
community PRs from the community PR: reviewed-changes-requested Some / all of the reviewers have requested for changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[API] List all conversations, without status filter
3 participants