-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add filter status=all to conversation list and meta #8994
docs: Add filter status=all to conversation list and meta #8994
Conversation
@danilofuchs Thanks for the PR. This is helpful. However, you need to edit this someplace else. Please see the screenshot below. swagger.json is a generated file. You would have to run Please see the guide here. https://www.chatwoot.com/hc/handbook/articles/swagger-documentation-31 If I had edit permission, I could have done that myself. For some reason, I cannot push to this branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see the comment above.
@pranavrajs |
Great, thanks! Merging it now. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Pull Request Template
Description
The code skips filtering if status=all in the query params, but the documentation was out of date:
https://github.com/SalvyLTD/chatwoot/blob/3fec1e195e3c4f5e3d41e6180f0b96d07de40e72/app/finders/conversation_finder.rb#L130
Closes #8993
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Checklist: