Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Inbox view enhancements #9049

Merged
merged 22 commits into from
Mar 8, 2024
Merged

feat: Inbox view enhancements #9049

merged 22 commits into from
Mar 8, 2024

Conversation

iamsivin
Copy link
Member

@iamsivin iamsivin commented Mar 1, 2024

Pull Request Template

Description

This PR includes

  1. Fix the back button to redirect to the inbox view and separate the expanded layout used in the conversation screen.
  2. Now uses notification ID for the route instead of conversation ID and moves the route config from conversation routes.
  3. Close the inbox list display and options menu if the inbox card context menu is open.
  4. Removed the list end message.
  5. Minor clean up

Fixes

  1. https://linear.app/chatwoot/issue/CW-3061/why-is-there-an-expanded-view-in-inbox
  2. https://linear.app/chatwoot/issue/CW-3062/the-url-uses-conversation-id-it-should-be-the-notification-id
  3. https://linear.app/chatwoot/issue/CW-3063/dropdown-doesnt-work-properly-overlapping-menus-can-be-seen
  4. https://linear.app/chatwoot/issue/CW-3066/remove-the-end-of-list-message-it-is-not-required

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Loom video
https://www.loom.com/share/b9af53b1bda14168b10e3c8d927959f2?sid=63f2db3c-f963-4b65-bce4-238dba989604

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@iamsivin iamsivin self-assigned this Mar 1, 2024
@pranavrajs pranavrajs temporarily deployed to chatwoot-pr-9049 March 2, 2024 00:09 Inactive
@iamsivin iamsivin requested a review from muhsin-k March 6, 2024 18:47
@pranavrajs pranavrajs merged commit 0685e04 into develop Mar 8, 2024
13 of 16 checks passed
@pranavrajs pranavrajs deleted the feat/inbox-view-route branch March 8, 2024 02:27
Copy link

github-actions bot commented Apr 7, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants