-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add push notification when SLA missed #9078
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
questions
- should we add different SLA missed types for first_response , followup_response and resolution ?
- should we alert all members ? or should me limit to administrators / participants ?
- can we add a spec to ensure that notification is created ?
- can we also test that this won't break email / push notifications since we aren't additing to the notification preferences
Yes
Participants + Admin |
@sojan-official @pranavrajs Done. Could you take another look? |
"conversation_mention": "Mention", | ||
"sla_missed_first_response": "SLA Missed", | ||
"sla_missed_next_response": "SLA Missed", | ||
"sla_missed_resolution": "SLA Missed" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How can we distinguish between different SLA types in the front end if we use the same translation for all types?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vishnu-narayanan Please check the comments.
@muhsin-k Done. Could you please review again? |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Pull Request Template
Description
The notification is send to all users part of the conversation inboxFixes https://linear.app/chatwoot/issue/CW-3098/in-app-notification-if-sla-is-missed
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist: