Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add push notification when SLA missed #9078

Merged
merged 9 commits into from
Mar 11, 2024
Merged

Conversation

vishnu-narayanan
Copy link
Member

@vishnu-narayanan vishnu-narayanan commented Mar 7, 2024

Pull Request Template

Description

  • Add in-app notification when SLA target is missed for a conversation
  • The notification is send to all users part of the conversation inbox
  • Notification is sent to all conversation participants, admins and assignee if present
image

Fixes https://linear.app/chatwoot/issue/CW-3098/in-app-notification-if-sla-is-missed

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Tested locally by creating a conversation and waiting for the SLA target to miss
  • This created an in-app notification

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

linear bot commented Mar 7, 2024

Copy link
Member

@sojan-official sojan-official left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

questions

  • should we add different SLA missed types for first_response , followup_response and resolution ?
  • should we alert all members ? or should me limit to administrators / participants ?

@pranavrajs


@vishnu-narayanan

  • can we add a spec to ensure that notification is created ?
  • can we also test that this won't break email / push notifications since we aren't additing to the notification preferences

@pranavrajs
Copy link
Member

should we add different SLA missed types for first_response , followup_response and resolution ?

Yes

should we alert all members ? or should me limit to administrators / participants ?

Participants + Admin

@vishnu-narayanan
Copy link
Member Author

@sojan-official @pranavrajs Done. Could you take another look?

@vishnu-narayanan vishnu-narayanan temporarily deployed to chatwoot-pr-9078 March 8, 2024 18:38 Inactive
"conversation_mention": "Mention",
"sla_missed_first_response": "SLA Missed",
"sla_missed_next_response": "SLA Missed",
"sla_missed_resolution": "SLA Missed"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can we distinguish between different SLA types in the front end if we use the same translation for all types?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's being used to tag notifications. Adding specific texts would feel repetitive as the notification sub text clearly distinguishes between SLA misses. image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

Copy link
Member

@muhsin-k muhsin-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vishnu-narayanan Please check the comments.

@vishnu-narayanan
Copy link
Member Author

@muhsin-k Done. Could you please review again?

@vishnu-narayanan vishnu-narayanan temporarily deployed to chatwoot-pr-9078 March 11, 2024 15:41 Inactive
@vishnu-narayanan vishnu-narayanan merged commit aaf70cf into develop Mar 11, 2024
16 checks passed
@vishnu-narayanan vishnu-narayanan deleted the feat/sla-13 branch March 11, 2024 16:19
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants