chore: Add validation to prevent message flooding #9254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sojan-official
commented
Apr 17, 2024
sojan-official
commented
- Add a validation to limit messages created per minute to avoid message flooding cases.
pranavrajs
reviewed
Apr 18, 2024
pranavrajs
approved these changes
Apr 18, 2024
Co-authored-by: Pranav <pranav@chatwoot.com>
pranavrajs
reviewed
Apr 18, 2024
app/models/message.rb
Outdated
| return if conversation.blank? | ||
|
|
||
| # there are cases where automations can result in message loops, we need to prevent such cases. | ||
| errors.add(:base, 'Too many messages') if conversation.messages.where('created_at >= ?', |
There was a problem hiding this comment.
- Extend the limit to 200 per minute.
- Add Rails.logger for the error.
- Create an alert on NewRelic for this error.
sojan-official
commented
Apr 18, 2024
|
|
||
| # there are cases where automations can result in message loops, we need to prevent such cases. | ||
| if conversation.messages.where('created_at >= ?', 1.minute.ago).count >= Limits.conversation_message_per_minute_limit | ||
| Rails.logger.error "Too many message: Account Id - #{account_id} : Conversation id - #{conversation_id}" |
There was a problem hiding this comment.
@vishnu-narayanan Could you add a trigger for this one ?
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.