Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add button component #9276

Merged
merged 21 commits into from Apr 25, 2024
Merged

feat: Add button component #9276

merged 21 commits into from Apr 25, 2024

Conversation

muhsin-k
Copy link
Member

@muhsin-k muhsin-k commented Apr 22, 2024 •
edited

Light theme Dark theme
CleanShot 2024-04-24 at 21 05 57@2x CleanShot 2024-04-24 at 21 05 47@2x

@linear Linear
Copy link

linear bot commented Apr 22, 2024

CW-3220 Button component

@muhsin-k muhsin-k marked this pull request as ready for review April 25, 2024 05:09
@muhsin-k muhsin-k self-assigned this Apr 25, 2024
scmmishra
scmmishra reviewed Apr 25, 2024
View reviewed changes
app/javascript/v3/components/Form/Button.vue Outdated Show resolved Hide resolved
app/javascript/v3/components/Form/Button.vue Outdated Show resolved Hide resolved
app/javascript/v3/components/Form/Button.vue Outdated Show resolved Hide resolved
app/javascript/v3/components/Form/Button.vue Outdated Show resolved Hide resolved
app/javascript/v3/components/Form/Button.vue Outdated Show resolved Hide resolved
@scmmishra
Copy link
Member

@muhsin-k added some points, also can you ensure this handles RTL direction also

@muhsin-k
Copy link
Member Author

@scmmishra All the review comments are addressed. RTL direction is also working fine.

@muhsin-k muhsin-k requested a review from scmmishra April 25, 2024 06:07
scmmishra
scmmishra requested changes Apr 25, 2024
View reviewed changes
Copy link
Member

@scmmishra scmmishra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last few points, everything else looks good to go. Let's also add tests for this component

app/javascript/v3/components/Form/Button.vue Outdated Show resolved Hide resolved
app/javascript/v3/components/Form/Button.vue Outdated Show resolved Hide resolved
@muhsin-k muhsin-k requested a review from scmmishra April 25, 2024 07:40
@muhsin-k muhsin-k temporarily deployed to chatwoot-pr-9276 April 25, 2024 08:32 Inactive
@muhsin-k muhsin-k merged commit 04ae380 into develop Apr 25, 2024
12 of 13 checks passed
@muhsin-k muhsin-k deleted the feature/cw-3220 branch April 25, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scmmishra scmmishra scmmishra approved these changes

@iamsivin iamsivin Awaiting requested review from iamsivin

Assignees

@muhsin-k muhsin-k

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@muhsin-k @scmmishra @vishnu-narayanan