Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sitemap for help center #9280

Merged
merged 13 commits into from Apr 26, 2024
Merged

feat: add sitemap for help center #9280

merged 13 commits into from Apr 26, 2024

Conversation

scmmishra
Copy link
Member

@scmmishra scmmishra commented Apr 23, 2024

This PR adds a sitemap to the help center, it lists the published articles along with the last modified date. When configured with a custom domain, it can help improve SEO

image

Type of change

  • New feature (non-breaking change which adds functionality)

Pending

  • Verify URL generation with custom domain
  • Unit tests to ensure correct domain is used, the XML is valid, and only published articles show up
  • Explore styling of the sitemap like it is done for our website
  • Add the sitemap link to the meta tag

@scmmishra scmmishra marked this pull request as draft April 23, 2024 09:06
@scmmishra scmmishra marked this pull request as ready for review April 26, 2024 07:08
@pranavrajs
Copy link
Member

Code looks fine, I've not tested it locally. If you have tested this properly, please go ahead and merge. 👍

@scmmishra scmmishra merged commit 78f9451 into develop Apr 26, 2024
15 of 16 checks passed
@scmmishra scmmishra deleted the feat/hc-sitemap branch April 26, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants