feat: don't allow dropdown navigation on input focused #9341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scmmishra
changed the title
iamsivin
approved these changes
May 2, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://linear.app/chatwoot/issue/CW-3266/i-cannot-click-up-or-down-arrow-buttons-in-the-editor
In #9242 we refactored keyboard shortcuts to use a declarative approach, using
tinykeysas the base.There was another change in the PR that allowed these shortcuts to run even when the input was triggered. To enable this behaviour, we had to prevent default in multiple places, this was because running these shortcuts like
Alt+Ofor example would render associated ASCII characters with it.In order to prevent that we added
preventDefaultto the keyboard event. In this case, the keyboard event was added to theArrowUpandArrowDownhandler. This overrode the default action inside the editor. This PR fixes thisFuture Work
documentobject, we need to update the mixin to allow arbitrary targets within the component.allowOnFocusedInputis set totrueand the keys pressed with any modifiers, for the rest we can let the event continue to propagate and trigger default as well.