Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds backend support for rendering tables in articles #9526

Merged
merged 7 commits into from
May 24, 2024

Conversation

iamsivin
Copy link
Member

Pull Request Template

Description

This PR will add backend support to render a table on the article page.

Fixes https://linear.app/chatwoot/issue/CW-3292/table-feature-in-help-center

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Screenshot
Before
image

After
image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

linear bot commented May 23, 2024

@iamsivin iamsivin requested a review from muhsin-k May 23, 2024 06:21
@iamsivin iamsivin marked this pull request as draft May 23, 2024 06:21
@sojan-official sojan-official temporarily deployed to chatwoot-pr-9526 May 24, 2024 00:17 Inactive
@sojan-official sojan-official marked this pull request as ready for review May 24, 2024 00:17
@sojan-official
Copy link
Member

  • verified in local by creating an article directly in db
This is a **bold** text and *italic* text.

| Header1      | Header2      |
| ------------ | ------------ |
| **Bold Cell**| *Italic Cell*|
| Cell3        | Cell4        |
Screenshot 2024-05-23 at 5 23 47 PM

@sojan-official sojan-official changed the title feat: Adds backend support for rending table in article feat: Adds backend support for rendering tables in articles May 24, 2024
@iamsivin iamsivin merged commit 7c5e67b into develop May 24, 2024
17 checks passed
@iamsivin iamsivin deleted the feat/CW-3292-backend branch May 24, 2024 03:14
clairton pushed a commit to clairton/chatwoot that referenced this pull request Jun 13, 2024
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants