Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use message sender ID in the analytics for first response time #9605

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

pranavrajs
Copy link
Member

@pranavrajs pranavrajs commented Jun 7, 2024

conversation.assignee_id was taken into consideration for first response time calculation. There was one flaw in this approach. A lot of customer support agents respond to the conversation first before assigning it to themselves. This makes the analytics broken.

To fix this, we will take the message sender instead of assignee in calculations, which should solve the issue with metric.

Fixes https://linear.app/chatwoot/issue/CW-3375/first-response-reporting-events-use-assignee-id-instead-of-agent-who

`conversation.assignee_id` was taken into consideration for first response time
calculation. There was one flaw in this approach. A lot of customer support agents
respond to the conversation first before assigning it to themselves. This makes the
analytics broken.

To fix this, we will take the message sender instead of assignee in calculations, which
should solve the issue with metric.
Copy link

linear bot commented Jun 7, 2024

@pranavrajs pranavrajs temporarily deployed to chatwoot-pr-9605 June 7, 2024 01:55 Inactive
@sojan-official
Copy link
Member

Verified locally that first response reports are getting generated correctly even if the agent is not the assignee

@sojan-official sojan-official merged commit 576c584 into develop Jun 7, 2024
16 checks passed
@sojan-official sojan-official deleted the fix/message-user-id branch June 7, 2024 03:20
Copy link

github-actions bot commented Jul 7, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants