Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SRE-1226: twistlock chart #108

Merged
merged 6 commits into from Nov 26, 2019
Merged

SRE-1226: twistlock chart #108

merged 6 commits into from Nov 26, 2019

Conversation

cw-sakamoto
Copy link
Contributor

@cw-sakamoto cw-sakamoto commented Nov 18, 2019 •
edited

  • twistlock console, defender chart
  • You can install defender with daemonset or deployment
    • Default is daemonset.
  • An access token is also required to pull image, the test cannot be performed and Makefile is dummy.

cw-ozaki
cw-ozaki reviewed Nov 21, 2019
View reviewed changes
twistlock-console/README.md
| `config.runConsoleAsRoot` | Run Twistlock Console processes as root (default, twistlock user account) | `false` |
| `config.docker.tag` | docker image tag| `"_19_07_363"` |
| `config.docker.socket` | docker socket path| `"/var/run/docker.sock"` |
| `config.backup` | Enable backup (but same volume) | `"true"` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cw-sakamoto
is recovery better? I think config should match twistlock term.
https://github.com/chatwork/charts/pull/108/files#diff-03ec088724602823998d433a7dba6d90R150

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same setting should be the same item.
https://github.com/chatwork/charts/pull/108/files#diff-e7753711c3da374637f8f54d0e1238c7R43-R44

What about the following structure?

persistence:
  enabled: true
  mountPath: /var/lib/twistlock-backup
  subPath: twistlock-backup

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cw-ozaki

is recovery better?

Sure, I think so! I' ll change.

mountPath: /var/lib/twistlock-backup

Unfortunately, this path cannot be changed due to a bug in the product😞
I don't like the pass, so I tried to change it, but happened error...!!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh...

@cw-ozaki
Copy link
Contributor

@cw-sakamoto
Does Ingress need to support twistlock-console?
I think there are use cases that need it. For example, to allow users with specific IP access to twistlock-console on EKS.

@cw-sakamoto
Copy link
Contributor Author

#108 (comment)

I forgot ingress!! I'll add template for ingress.

@cw-sakamoto cw-sakamoto merged commit bfed19b into master Nov 26, 2019
@cw-sakamoto cw-sakamoto deleted the SRE-1226_twistlock branch November 26, 2019 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cw-ozaki cw-ozaki cw-ozaki left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cw-sakamoto @cw-ozaki