Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all dependencies incl typeorm 0.2.0 -> 0.3.0 #405

Merged
merged 22 commits into from Apr 15, 2024

Conversation

annarhughes
Copy link
Member

@annarhughes annarhughes commented Apr 10, 2024

What changes did you make?

Major update of all dependencies

Includes

  • significant updates to all dependencies
  • updated node version from v16 to v20
  • major update from typeorm 0.2.0 -> 0.3.0 - see required changes below
  • update to eslint config which fixed linting false positives. Many linting fixes applied once they were flagged e68a25d

Typeorm >0.3.0 changes - see guide for more details:

  • removed ormconfig support and replaced with new DataSource
  • all entities and migrations must now be imported to dataSourceOptions in typeorm.config.ts
  • our custom repositories (e.g. /user/user.repository.ts) were causing errors (EntityMetadataNotFoundError) and as the custom repository didn't add any functionality, these were removed in favour of using the typeorm default Repository<UserEntity> - this caused the most file changes
  • findOne replaced with findOneBy including many other function changes. We should complete a follow up review of all typeorm functions used in the app to ensure they are still the most efficient, vs new nesting join methods

Why did you make the changes?

  • The updates were required for maintenance to improve performance and security. Triggered by issues running backend locally - which may have been a direct/indirect result of outdated packages.

@annarhughes annarhughes changed the title WIP: Deps update all Update all dependencies incl typeorm 0.2.0 -> 0.3.0 Apr 11, 2024
@annarhughes annarhughes merged commit 2457feb into develop Apr 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants