New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update all dependencies incl typeorm 0.2.0 -> 0.3.0 #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eleanorreem
reviewed
Apr 11, 2024
annarhughes
changed the title
WIP: Deps update all
Update all dependencies incl typeorm 0.2.0 -> 0.3.0
Apr 11, 2024
This was referenced Apr 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes did you make?
Major update of all dependencies
Includes
Typeorm >0.3.0 changes - see guide for more details:
ormconfig
support and replaced withnew DataSource
dataSourceOptions
intypeorm.config.ts
/user/user.repository.ts
) were causing errors (EntityMetadataNotFoundError
) and as the custom repository didn't add any functionality, these were removed in favour of using the typeorm defaultRepository<UserEntity>
- this caused the most file changesfindOne
replaced withfindOneBy
including many other function changes. We should complete a follow up review of all typeorm functions used in the app to ensure they are still the most efficient, vs new nesting join methodsWhy did you make the changes?