Fix service user profiles throw error #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes did you make?
Remove
throw errorfromcreateServiceUserProfilesfunction. The service user profiles functions support our external comms profiles (mailchimp and crisp), however if there is an error creating or updating these external profiles, we don't want the original database/api route to fail. I.e. a users sign up request should not error due to crisp profile creation error, we should catch and log these errors only, but allow the api route to succeed.Why did you make the changes?
This is a new bug accidentally introduced in #428 , fixing so it doesn't cause errors on user sign up